Code Review sheet

Key:
Good
Acceptable
Unacceptable
N/A
Development Object Request ID:
Development Object Request Title:
Rev-Trac #
Transport #
Reviewer name:
Programmer:
Date:
Code review version:
Rework required:
Objects:

Naming Standards

STANDARDS

REVIEW

Report programs

N/A

Module Pool Programs

N/A

Function Modules & Groups

Includes - Module Pool

Includes - Program

N/A

N/A

N/A

N/A

COMMENTS

Authorization objects

N/A

Batch Input Sessions

N/A

SAPscript(Forms)

N/A
N/A

SAPscript Print programs

Message Class

N/A

Area Menus

N/A

Transaction

N/A

Tables

N/A

Table Index

N/A
Acceptable

Domains

N/A

Data Elements

N/A

Fields

N/A

Views

N/A

Structure
Search helps Collective
Search helps Elemantary

Matchcode
Lock Objects

N/A

N/A

N/A

N/A

N/A

SAP Batch Jobs

Program Attributes

STANDARDS

Development Class

REVIEW

COMMENTS

N/A
N/A

Program type
Application area

N/A
N/A

Authorization group
Description
Documentation

N/A

STANDARDS

REVIEW

Proper program block heading

N/A

Appropriate code documentation

N/A

Standard Program Header

N/A

Data Declaration
Style
Technical attributes

STANDARDS

REVIEW
N/A
N/A

Parameters

N/A

Select-options

N/A

Ranges

N/A

Internal Tables
Structures
Global variables
Local variables (declared and used
within a subroutine)
Indexes
Contral variables
Counters

N/A
N/A
N/A
N/A
N/A
N/A
N/A

COMMENTS

COMMENTS

N/A

Flag
Constants

N/A
N/A

Types
Field Groups

N/A

Field Symbols

N/A

Data Declaration Names

Correct occurs clause

N/A

Selection Screen

N/A

STANDARDS

REVIEW

Appearance

N/A

Appropriate defaults

N/A

Appropriate validations

N/A

Parameter ids

N/A

COMMENTS

Program Structure
STANDARDS
Correct event flow
ABAP report programs (depends on object)

REVIEW
N/A
N/A
N/A

COMMENTS

N/A

Forms
Correct use of forms
Documentation

STANDARDS

COMMENTS

N/A
N/A

Form input / output parameters

Coding Style

REVIEW

N/A

STANDARDS

REVIEW

Paper Size

N/A

Comments
INCLUDE

N/A
N/A

COMMENTS

SELECT (only commonly used)

USE

AVOID

REVIEW

Select with select list

N/A

Select single

N/A

Select with WHERE condition

N/A

COMMENTS

N/A

Select using an aggregate function

N/A

Select into Table

N/A

Array Insert

N/A

Order By (if use of index) otherwise use

SORT itab BY in an internal table

N/A

View or Internal Tables

N/A

INTERNAL TABLE (only commonly used)

USE
AVOID

REVIEW

MOVE

N/A

Sort with sort key specified explicitly

N/A

Binary Search of an internal table

N/A

APPEND

N/A

Error Control

STANDARDS

REVIEW

Proper error control

N/A

Appropriate error/success messages

output

N/A

COMMENTS

COMMENTS

STANDARD INCLUDES
Use standard FM for Interface
User standard FM for report

STANDARD

REVIEW
N/A
N/A
Good

COMMENTS