Past simple or present perfect?

de English Grammar Today

Past simple = I worked Present perfect = I have worked

 
Definite time in the past

We use the past simple to refer to definite time in the past (when we specify the time or how long) and usually

with past time expressions such as yesterday, two weeks ago, last year, in 1995:

We  met in January 1975. We went to America together in 1978.

Not: We have met in January 1975. We have gone to America together in 1978 .

 
Time up to now

We use the present perfect to talk about time up to now, that is, events that took place in the past but which

connect with the present. The present perfect is often used with time expressions which indicate time up to

now, for example today, this year, in the last six months:

I  haven’t seen her since January 1995.

Not: I didn’t see her since January 1995 .

Compare

I  haven’t seen  her for The last time I saw her

over 20 years. was over 20 years ago.

I  didn’t see her for over I saw her last week but

20 years and then the last time I saw her
I  bumpedinto her last before last week was
week. over 20 years ago.
Compare

I  finished my Definite time in the past.

homework  an hour I finished my homework at a
ago. time in the past (one hour ago).

From a time in the past up to

now.
I  haven’t
I started my homework at a
finished  my
time in the past and it is not
homework  yet.
finished yet (yet means ‘up to
now’).

Definite time in the past. We

We had a good
had a good day in the past
day yesterday.
(yesterday).

From a time in the past up to

We have had  a now.
good day so far. The day has been good until
now but it hasn’t finished yet.

We didn’t Definite time in the past (last

seeDiana last week. week).

We haven’t
From the beginning of the
seen  Diana this
week until now.
week.

Today is not finished but it is

I  didn’t haveany
almost the end of the day and
lunchtoday.
past lunchtime.

I  haven’t hadany It is still today and not too late

lunchtoday. to have lunch.